Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved rowCount() from Statement to ResultStatement #4035

Merged
merged 1 commit into from
May 28, 2020
Merged

Moved rowCount() from Statement to ResultStatement #4035

merged 1 commit into from
May 28, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented May 28, 2020

Q A
Type improvement
BC Break yes

This is a backport of #3483 needed to continue the rework of the Statement and ResultStatement interfaces.

@morozov morozov added this to the 3.0.0 milestone May 28, 2020
@morozov morozov requested a review from greg0ire May 28, 2020 05:51
@morozov morozov merged commit 74eca6b into doctrine:3.0.x May 28, 2020
@morozov morozov deleted the row-count branch May 28, 2020 06:54
@morozov morozov self-assigned this Jun 6, 2020
cedricbonhomme added a commit to monarc-project/zm-core that referenced this pull request Apr 5, 2022
@cedricbonhomme
rowCount() has benn moved from Statement to ResultStatement (doctrine…
7b8463f 
…/dbal#4035)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
BC Break Improvement Prepared Statements
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire